XCD-176 IPad Cut Mode #1770
Merged
XCD-176 IPad Cut Mode #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a point on the axis closest to the pointer ray (also #1717)
…d not on hoverEnter/hoverOutEntity (those would interfere with touch events)
…on - not only to setPosFromSectionPlane, but also (new) to drag action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes introduced by this PR:
XEOK-125 Change the way axis interaction is interpreted - looking for a point on the axis closest to the pointer ray (also #1717).
Instead intersecting the pointer/touch ray with a fixed plane (which would sometimes be parallel to the ray direction), the interaction now looks for a closest point between the ray and an axis line.
CHANGE SectionPlanesPlugin::Control to rely only on canvas events, and not on hoverEnter/hoverOutEntity (those would interfere with touch events).
This also removes a "weird" section plane control behaviour, when a mouse click would activate it, even if the pointer was not hovering the gizmo.
XCD-176 Add SectionPlanesPlugin::Control touch events support