Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore flexbox for horizontal panel header titles. #3458

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Restore flexbox for horizontal panel header titles. #3458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08f2418
Restore flexbox for horizontal panel header titles.
TomTirapani Aug 22, 2023
bf52e9b
Merge branch 'develop' into panelHeaderFlex
amcclain Aug 23, 2023
0e9fe38
Changelog entry
amcclain Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
* Restored support for `Select.selectOnFocus` (had broken with upgrade to `react-select` in v59.0).
* Fixed `DateInput` bug caused by changes in Chrome v116 - clicking on inputs
with `enableTextInput: false` now open the date picker popup as expected.
* Flex inner title element added to `Panel` headers in v59.0, and set `display:flex` on the new
element itself. Restores previous flexbox container behavior (when not L/R collapsed) for apps
that are providing custom components as titles.

## 59.0.1 - 2023-08-17

Expand Down
7 changes: 7 additions & 0 deletions desktop/cmp/panel/impl/PanelHeader.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@
white-space: nowrap;
font-family: var(--xh-panel-title-font-family);
font-size: var(--xh-panel-title-font-size-px);

&__inner {
display: flex;
flex: 1;
}
}

&__items {
Expand Down Expand Up @@ -45,6 +50,8 @@
height: 100%;

&__inner {
display: block;
flex: none;
margin-top: 50%;
transform: rotate(90deg);
height: calc(1em + 5px);
Expand Down