DiligentFX: add package #7116
Merged
DiligentFX: add package #7116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How to limit arm64 for linux, I tried |
There was a problem hiding this comment.
Pull Request Overview
This PR implements the new port for DiligentFX by updating dependency management, refactoring patch files, and modernizing the CMake configuration.
- Conditionally updates the USD package’s dependency on TBB based on version
- Splits the monolithic patch file into several smaller, focused patches
- Upgrades CMakeLists.txt and related scripts to use pkg-config and updated include paths
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/u/usd/xmake.lua | Adds a conditional dependency on TBB for different USD versions |
| packages/d/diligentfx/xmake.lua | Introduces new port settings and resource management for DiligentFX |
| Various patches in packages/d/diligentfx/patches/v2.5.6/ | Refactors include statements and updates build configurations to use modern DiligentCore include paths and pkg-config |
| CMakeLists.txt and related CMake patches | Modernizes the build infrastructure with improved dependency detection and installation rules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6622
limit linux arm64 (usd dep/tbb dep)use newest tbb/usd