feat: custom eslint configuration #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlvieras
requested review from
gpicart,
lauta2912,
chaba11,
aperezcastagnino,
andynm,
victor1mrs and
gabrielmachin
mlvieras
force-pushed
the
feature-eslint-configuration
branch
from
ccf1261
to
2a7b792
Compare
lauta2912
reviewed
Nov 13, 2024
lauta2912
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Copilot reviewed 50 out of 65 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- .prettierrc: Language not supported
- package.json: Language not supported
- src/common/app-link/app-link.stories.tsx: Evaluated as low risk
- src/common/badge/badge.tsx: Evaluated as low risk
- README.md: Evaluated as low risk
- src/common/avatar/avatar.test.tsx: Evaluated as low risk
- src/app.test.tsx: Evaluated as low risk
- src/common/button/button.tsx: Evaluated as low risk
- src/app.tsx: Evaluated as low risk
- src/common/base-button/base-button.test.tsx: Evaluated as low risk
- src/common/badge/badge.stories.tsx: Evaluated as low risk
- src/common/app-link/app-link.tsx: Evaluated as low risk
- src/common/error-boundary/error-boundary.test.tsx: Evaluated as low risk
- src/common/button/button.stories.tsx: Evaluated as low risk
- src/common/avatar/avatar.stories.tsx: Evaluated as low risk
| } | ||
| export const getExamples = async (): Promise<Example[]> => { | ||
| const response = await ApiService.get<RawExample[]>(API_ROUTES.EXAMPLE); | ||
| return response.map<Example>(deSerialize); |
There was a problem hiding this comment.
Do we want to update these examples in the README? This one in particular in the Networking section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket/Card
Description of the change
This PR updates our Eslint rules. Most importantly, I've removed the Airbnb Eslint configuration packages. Let's break this down.
Removal of
eslint-config-airbnbandeslint-config-airbnb-typescriptThe rationale here is that our linting rules are hidden behind a package which is not owned by us, and so it's hard to know what our actual standards are and have an open discussion around them. Another argument against using those packages is that we're fully dependent on those packages being updated in order to update our Eslint version (and even plugin versions).
Finally, this forces us to understand what plugins we have installed and it's much easier to make changes to the configuration.
Rule changes
I've tried to keep as much of our rules as possible, but also have taken the chance to make some changes I think are necessary.
As far as plugins go, I've ported the React, React Hooks and JSX A11y plugins from Airbnb's configuration.
Other changes
.prettierrcfile since I was having a conflict with VS Code and format-before-save.ParamsHelper.Next Steps