Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count outbound stanzas from enable sent #1067

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Count outbound stanzas from enable sent #1067

wants to merge 1 commit into from

Conversation

singpolyma
Copy link
Contributor

@singpolyma singpolyma commented Feb 19, 2025 •
edited
Loading

Not from enabled/online. As per XEP https://xmpp.org/extensions/xep-0198.html#example-7

<!-- Client -->
<enable xmlns='urn:xmpp:sm:3'/>

<!-- Client sets outbound count to zero. -->

<message from='[email protected]/churchyard'
         to='[email protected]'
         xml:lang='en'>
  <body>
    I'll send a friar with speed, to Mantua,
    with my letters to thy lord.
  </body>
</message>

<!-- Note that client need not wait for a response. -->

we were setting to zero correctly, but holding at zero and not queuing stanzas until after <enabled/> came back, which is wrong as seen here things should be counted and queued right from after the <enable/> is sent.

@sonnyp
Copy link
Member

sonnyp commented Feb 19, 2025

Please update description to clarify what this does and why.

Sounds like a test might also be appropriate.

@singpolyma
Count outbound stanzas from enable sent
f6658e6 
Not from enabled/online. As per XEP
@singpolyma singpolyma force-pushed the count-from-enable-sent branch from a978318 to f6658e6 Compare February 19, 2025 20:47
@singpolyma
Copy link
Contributor Author

test added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@singpolyma @sonnyp