feat: Bring back Impala support #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes the Impala driver from the abandoned bippio/go-impala to the maintained sclgo/impala-go. - Moves Impala from the "bad" to the "most" driver set - Add MetaReader for Impala - Implements copy for Impala, extending the generic CopyWithInsert with an option to work without transactions - for DBs that don't support them - Implements IsPasswordErr The PR targets release-19, not master, so that the CI confirms no regressions caused by the change in drivers.CopyWithInsert. (CI on master is broken). The commit shouldn't create issues when it is cherry-picked to master afterwards.
|
@murfffi you are the best. I'll review when I'm out of bed and add first thing. |
kenshaw
added a commit
to xo/homebrew-xo
that referenced
this pull request
Apr 6, 2025
## What's Changed * feat: Bring back Impala support by @murfffi in xo/usql#518 **Full Changelog**: xo/usql@v0.19.20...v0.19.21 * [usql_static-0.19.21-linux-amd64-0a28f833](https://www.virustotal.com/gui/file-analysis/YzU1YmM2ODQ2NmFkYjBkYjAwZDNjZjAwYWUyZDUyZmU6MTc0Mzk3MzYwNw==/detection) * [usql_static-0.19.21-linux-arm64-5a0573d8](https://www.virustotal.com/gui/file-analysis/NjA5Yjg1YTJkNmViY2RkYjA0Yjk4MGEwN2ZhNTQwMWY6MTc0Mzk3MzYxMA==/detection) * [usql-0.19.21-darwin-amd64-dc5bb34a](https://www.virustotal.com/gui/file-analysis/ODE0YTUyNmE0MWMwYTc0ZjMwNzc0ZWRlOTJjMDM4NzY6MTc0Mzk3MzYxMw==/detection) * [usql-0.19.21-darwin-arm64-61dd8055](https://www.virustotal.com/gui/file-analysis/Y2U1MmY1OTc4NWJjZmY5MGZhMmI1NDFkMjBlNTIzNGI6MTc0Mzk3MzYxNw==/detection) * [usql-0.19.21-darwin-universal-fcbacbba](https://www.virustotal.com/gui/file-analysis/YzE0NWRiNzRkMmI5MDQ4ZWM3NDJlMzA5MjBkMjY2ZmI6MTc0Mzk3MzY2OQ==/detection) * [usql-0.19.21-linux-amd64-a8d3937c](https://www.virustotal.com/gui/file-analysis/NTI5OTU0MDU0YzE4YzAzMmNjMjcxMGEzNTM5ZDg3OGY6MTc0Mzk3MzY3Mg==/detection) * [usql-0.19.21-linux-arm-c552fd74](https://www.virustotal.com/gui/file-analysis/OGRkNGM5ZTU2NzNkYTc0NTBlNGI5ZGQ2ZjY2MTdjY2Q6MTc0Mzk3MzY3NQ==/detection) * [usql-0.19.21-linux-arm64-c469114f](https://www.virustotal.com/gui/file-analysis/OTNmNDBiYjc3MDQ1OTVmMTRlZTg4Y2M1MDQwZDg2MzU6MTc0Mzk3MzY3Nw==/detection)
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR brings back Impala support as discussed in #517
The PR targets release-19, not master, so that the CI confirms no regressions caused by the change in drivers.CopyWithInsert. (CI on master is broken). The commit shouldn't create issues when it is cherry-picked to master afterwards.
I tested for regressions in CopyWithInsert with
Closes #517