New tests for TVTs

[ndw]

It seems surprising that there were no tests for inserting XML into text documents with TVTs, but since I was doing it wrong, I assume there weren't.

@xml-project I wonder if you agree with these results?

[ndw]

For the moment, I've special cased inserting attributes, see xproc/3.0-specification#1131

[xml-project]

I think 002 should raise XD0052, not XD0030.

[ndw]

The phrasing of XD0052 suggests that you should be able to use TVTs to add attributes to elements in an XML context. Do you have an example that does that? I can't construct one, but that may be a bug.

[xml-project]

On thinking about it again: I think "nw-tvt-002" should pass. An attribute (as result of the TVT) is added to the surounding element. So the result, I would expect, is:
<wrapper><copy name="value" /></wrapper>

[ndw]

Yes. I think you're right, nw-tvt-002 should pass. I'm just going to leave this PR open until (a) I think I've sorted out my implementation and maybe until (b) we've talked about the spec bug.

[ndw]

Except I forgot to change it so nw-tvt-002 passes. Another PR coming in a bit...

[ndw]

Okay. I think these are correct. I'm sure @xml-project will tell me if I'm mistaken :-)

[xml-project]

@ndw wrote:

Okay. I think these are correct. I'm sure @xml-project will tell me if I'm mistaken :-)

I do think to, these are correct. Thank you!

[ndw]

👍