Skip to content

Fix: lstsq compilation with complex<float> inputs #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: lstsq compilation with complex<float> inputs #251

wants to merge 2 commits into from

Conversation

deniz-unal
Copy link

This fix resolves a compilation error gelsd.tcc:146:25: error: invalid conversion from 'const float*' to 'cxxlapack::FLOAT_COMPLEX*' when linalg::lstsq is called with complex arguments.
Note that complex<double> and other types were unaffected.

  • A test case that demonstrates the issue is added to test/test_linalg.cpp
  • The fix adds const to the relevant interface to correctly match the expected input data type
  • The test compiles and passes with this fix

@deniz-unal
Add failing test for complex float input in lstsq
d7feb5b 
Add a test case to show the issue when using <std::complex<float>> with lstsq
@deniz-unal
Fix complex float inputs for lstsq
750a599 
Resolves compile error when lstsq is called with complex float arguments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deniz-unal