XWIKI-22821: Allow having generic analyzers for different types of macro arguments

[michitux]

Jira URL

https://jira.xwiki.org/browse/XWIKI-22821

Changes

Description

• Add a new MacroParameterRequiredRightsAnalyzer role.
• Add implementations for wiki content and macro content source references.

Clarifications

• This eliminates the need for XWIKI-22798: The code macro is missing a required rights analyzer #3810.
• As this fixes the bug of the missing required rights analyzer for the code macro, I propose backporting this improvement to the LTS branches.
• I put the parameter type as type parameter of the new role, but this type isn't used in the role anywhere so I added an explicit ignore for the warnings this causes. I don't know if we have a better solution for this.

Screenshots & Video

Example analysis of the following content:

{{code language="none" source="script:foo"}}{{/code}}

{{info title="{{groovy~}~}
println(~"Hello from Title~")
{{/groovy~}~}"}}
Type your information message here.
{{/info}}

Executed Tests

LANG=C.UTF-8 mvn clean install -Pdocker,legacy,integration-tests,snapshotModules,quality -pl :xwiki-platform-security-requiredrights-default,:xwiki-platform-security-requiredrights-macro

Expected merging strategy

• Prefers squash: Yes
• Backport on branches:
  • stable-16.10.x
  • stable-16.4.x

[tmortagne]

I propose backporting this improvement to the LTS branches

+1

I put the parameter type as type parameter of the new role, but this type isn't used in the role anywhere so I added an explicit ignore for the warnings this causes. I don't know if we have a better solution for this.

No better idea on my side.

[tmortagne]

Looks good (except for the surprising field I mentioned).

[github-actions]

💚 All backports created successfully

Status	Branch	Result
✅	stable-16.4.x
✅	stable-16.10.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details