XWIKI-22754: Use noavatar.png instead of noavatargroup.png for non-existing groups in macros.vm #3896
Conversation
…isting groups in macros.vm * add extra condition
|
My bad, if smth was changed in PR template and I didn't check before creation, I only noticed right now, in my mail that it returned error from backport action. I've removed mention of backport from PR description.
|
| @@ -361,7 +361,7 @@ $xwiki.getUserName("xwiki:${username}") | |||
| #macro(getUserAvatarURL $userName $return $size) | |||
| #set ($specified = false) | |||
| #set ($profileDoc = $xwiki.getDocument($userName)) | |||
| #if ($profileDoc.getObject('XWiki.XWikiGroups')) | |||
| #if ($profileDoc.getObject('XWiki.XWikiGroups') || !$profileDoc.getObject('XWiki.XWikiGroups')) | |||
There was a problem hiding this comment.
What's the point of this condition? Isn't this equivalent to true? And doesn't this mean it will always display noavatargroup and never noavatar even if it is actually a user?
There was a problem hiding this comment.
indeed, for not existing user it will use noavatargroup image
There was a problem hiding this comment.
I don't why but else statement won't never checked if I change statement for checking XWiki.XWikiUsers instead of XWiki.XWikiGroups
There was a problem hiding this comment.
for now I'll convert it to draft PR
Jira URL
XWIKI-22754: Use noavatar.png instead of noavatargroup.png for non-existing groups in macros.vm
Changes
Description
Clarifications
Screenshots & Video
Before
After
Executed Tests
Expected merging strategy