Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-22877: UIX in the information tab cannot load JavaScript and CSS resources #3901

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michitux
Copy link
Contributor

Jira URL

Changes

Description

  • Send skin extensions in the X-XWIKI-HTML-HEAD header.
  • Remove the duplicate loading of skin extensions from docextra.vm

Clarifications

  • I basically copied the code from attachmentsinline.vm which is used in the same ways so even though it seems strange to always send them (and not just when the template is loaded dynamically) I guess it should be fine.

Screenshots & Video

No UI changes.

Executed Tests

I ran the tests of the two modules, but they're not affected. I've manually tested the changed files, and I couldn't see any changes.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • stable-16.10.x?

…S resources

* Send skin extensions in the X-XWIKI-HTML-HEAD header.
* Remove the duplicate loading of skin extensions from docextra.vm
@michitux michitux self-assigned this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants