Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-18194: Exiting FullScreen from the gallery macro scrolls the page in a random location #3937

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Feb 27, 2025

Jira URL

https://jira.xwiki.org/browse/XWIKI-18194

Changes

Description

  • Focused the maximizeToggle button even when using a shortcut, so that it stays in the screen view.

Clarifications

  • When checking out the code, I figured out the exact same function call happens when clicking and pressing a key to minimize the gallery. Therefore the difference in behaviour must be related to "something else" that happens when clicking that does not happen when pressing the shortcut key. One of those things is that the user focus is set to the maximize toggle. I tried focusing the maximize toggle and this solved the bug. This change is pretty straightforward and doesn't impact much the user experience except for having correct scrolling.

Screenshots & Video

Here is a demo of how the gallery minimizing behaves with the changes.

2025-02-27.11-58-16.mp4

Executed Tests

Manual tests only, see video above.
Automatic tests didn't catch this behaviour, and the changes don't impact the DOM in any way, so I am almost certain that no automatic test will be broken by this change.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • 16.10.X (rather safe bugfix)

…ge in a random location

* Focused the maximizeToggle button even when using a shortcut, so that it stays in the screen view.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants