XWIKI-22931: The edit action modify the cached document when creating a page from template #3943
+48
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a page from template
* Fix XWikiDocument#copyAttachment to actually perform a real clone
including the copy of the content
* Introduce a XWikiAttachment#cloneWithActualContent to clone and copy
the content
* Introduce a XWikiAttachmentContent#clone(boolean) that allows to
decide to skip or not copying the content
WIP: right now tests are passing but it shows a regression in logs when
running PageTemplatesIT, probably due to the ownerDocument of
XWikiAttachmnentContent in clone method
surli
commented
Feb 27, 2025
| { | ||
| XWikiAttachmentContent clone = new XWikiAttachmentContent(this); | ||
| // this AttachmentContent is not attached to any document yet. | ||
| clone.setOwnerDocument(null); |
There was a problem hiding this comment.
Note that this is also used for the standard clone(), maybe we need to avoid that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22931
Changes
Description
WIP: right now tests are passing but it shows a regression in logs when running PageTemplatesIT, probably due to the ownerDocument of XWikiAttachmnentContent in clone method
Clarifications
Screenshots & Video
Executed Tests
Expected merging strategy