XRENDERING-771: Null pointer exception when list items occur without lists #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lists * Protect against list items without wrapping list. * Add tests.
surli
reviewed
Jan 24, 2025
| @@ -278,6 +278,10 @@ public void beginDocument(MetaData metadata) | |||
| public void beginDefinitionDescription() | |||
| { | |||
| ++this.inlineDepth; | |||
| if (this.definitionListDepth.isEmpty()) { | |||
There was a problem hiding this comment.
Why not encapsulating the content of the method in an if (!this.definitionListDepth.isEmpty()) { instead of adding artificially an element? Would that break something else?
There was a problem hiding this comment.
Hm, I thought so, but now I'm not so sure anymore. It seems that getListItemIndex already checks if the stack is non-empty, so this might actually be a better solution... It will break the printing of the list items in both XWiki syntax and plain text, but it might be cleaner.
There was a problem hiding this comment.
And +1 for having a warning in the else branch then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XRENDERING-771
Changes
Description
Clarifications
Screenshots & Video
No UI changes.
Executed Tests
Expected merging strategy