command-line parameters for retry attempts fix

[allbigbopper]

There is a fix for this issue [https://github.com//issues/64](Can't handle command-line parameters and using data from protractor.conf.js file for retry attempts instead). Would really appreciate if you take a look into it @davglass . Thanks!

[allbigbopper]

Hi @davglass, @amrot17. Could you please look into this one?

[amilbeck]

Hey @allbigbopper, I just tried this out with a small test suite from my setup and it didn't work. I turned on the debug statements so I could see the command that was actually running. There is a slight difference between the command between runs 1 and 2.

The first time the command is run the object looks like this:

ProtractorRetry ProtractorCommand {
    _: [ './dist/e2e/config/protractor-conf.js' ],
    help: false,
    version: false,
    baseUrl: 'https://my-url.com',
    params: { env: 'release' },
    suite: 'my_failing_suite',
    '$0': 'node_modules\\protractor\\bin\\protractor'
}

With the changes from this PR, the second attempt looks like it sent the command over as an array instead of a JSON object.

ProtractorRetry Command node_modules\protractor\bin\protractor [
  [ './dist/e2e/config/protractor-conf.js' ],
  '--specs',
  'C:\\repos\\my-app\\dist\\e2e\\specs\\my-failing-spec.spec.js',
  '--retry',
  1,
  '--disableChecks',
  '--baseUrl',
  'https://my-url.com',
  '--params.env',
  'release'
] 

It looks like it picked up all the command line flags I started the first run with but the command object is just not in the correct format. It's also missing the '$0' property. (Not sure if that actually matters). In any case it looks like this one is on the right path but just not quite there yet.

EDIT: Actually, I take that back. It looks like it does work. I just needed to change the way I am processing --params.env on my end and it started working.

[allbigbopper]

Thanks for review, really appreciate! Maybe I was just confused with 'var protractorCommand = []', and all .push() methods so it looked for me like an array, so I implemented it as an array and when I tested it perfectly worked for my project. Could you please share your small test project so I could check why it doesn't work?

[amilbeck]

See my edit to my previous comment. It was an issue on my end that was causing it to fail. Once I updated it started working.

[allbigbopper]

oh, it's great to hear 👍

[allbigbopper]

Hi @amilbeck. Do you think we could merge it?

[dreuxl]

sorry for delay, I maybe able to take a look at this one this week.

[viktorgogulenko]

Hey, guys. I'm really waiting for the fix of this issue as I have to generate lot of conf-files for every change instead of cli parameters. Thanks in advance for fix!

[amilbeck]

Hi @amilbeck. Do you think we could merge it?

I'm not a maintainer of this repo but for what it's worth, I forked this repo and included your changes. I've just been using my forked repo and it's been working fine for me for the last couple weeks. My guess is it's probably fine to merge but I don't have the final say.

[allbigbopper]

Hi @dreuxl! Do you think we could merge it?

[allbigbopper]

Hi @dreuxl! Could we please merge these changes?

[allbigbopper]

Hi @amilbeck, do you think we could merge it? We really need this fix. A fix has been around for 2 month

[amilbeck]

I think so. It's been working fine for me on my forked repo. I haven't had any issues at all. Been using it since Nov. 18, 2019. Works on both Linux and Windows for me. My local dev env is Windows and CICD pipeline runs on Linux. It's working great in both places.

[allbigbopper]

@dreuxl could you merge it please?? we really need a fix

[dreuxl]

ok I had to do my own PR for that because the test steps are not working for external PR , due to travis credential restriction to repo owner.

let me know how it goes @allbigbopper

[viktorgogulenko]

Any updates?

[dreuxl]

fixed in PR #70