Make TASKSTATS require root access

Ok, this isn't optimal, since it means that 'iotop' needs admin capabilities, and we may have to work on this some more. But at the same time it is very much not acceptable to let anybody just read anybody elses IO statistics quite at this level. Use of the GENL_ADMIN_PERM suggested by Johannes Berg as an alternative to checking the capabilities by hand. Reported-by: Vasiliy Kulikov <[email protected]> Cc: Johannes Berg <[email protected]> Acked-by: Balbir Singh <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
yanok · Sep 20, 2011 · 1a51410 · 1a51410
1 parent b6a68a5
commit 1a51410
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/kernel/taskstats.c b/kernel/taskstats.c
@@ -655,6 +655,7 @@ static struct genl_ops taskstats_ops = {
 	.cmd		= TASKSTATS_CMD_GET,
 	.doit		= taskstats_user_cmd,
 	.policy		= taskstats_cmd_get_policy,
+	.flags		= GENL_ADMIN_PERM,
 };
 
 static struct genl_ops cgroupstats_ops = {