Added custom PID support per image. Added line to documentation accordingly. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the `data-pid` attribute may be specified on the `img` tag. ISSUES: 1. Currently works whether or not the `galleryPIDs: true` option is set. Not sure if that's correct or not. 2. If `galleryPIDs` option IS set to `true`, then the page should automatically open the image with the custom PID in the URI, but this is not working properly yet. Only default PIDs will open. If a custom PID is in the URI when the page loads, as soon as the user clicks on ANY gallery image, the image with that custom PID will open, rather than the one the user clicked on.
|
As you said, if you use the custom pid PhotoSwipe it won't open the slide for you, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the
data-pidattribute may be specified on theimgtag. Added line in readme.md about thedata-pidattribute.ISSUES:
galleryPIDs: trueoption is set.Not sure if that's correct or not.
galleryPIDsoption IS set totrue, then the page shouldautomatically open the image with the custom PID in the URI, but this is
not working properly yet. Only default PIDs will open. If a custom PID
is in the URI when the page loads, as soon as the user clicks on ANY
gallery image, the image with that custom PID will open, rather than the
one the user clicked on.