Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inline comments in configuration file #94

Closed
wants to merge 1 commit into from
Closed

Allow inline comments in configuration file #94

wants to merge 1 commit into from

Conversation

dionysius
Copy link

@dionysius dionysius commented Jan 9, 2023

Cherry picked from #82.

  1. So discussion and review is on a per feature basis
  2. I see this as a really good QoL change
  • I don't see why any value would have a # sign
  1. smaller PR, easier to review
  2. due to cherry-pick will not break original PR

@dionysius
Copy link
Author

Damn, the cherry-pick is not enough. There are changes in various files regarding comments necessary. Ignore me

@dionysius dionysius closed this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants