-
Notifications
You must be signed in to change notification settings - Fork 15
fix: use shared getPDisksColumn implementation and storage node data preparation for cluster nodes #2729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ster nodes Co-authored-by: adameat <[email protected]>
|
Co-authored-by: adameat <[email protected]>
Fixed all the requested issues in commit 0ff46ab:
Column order now:
Both columns are available in the column selector but disabled by default as requested. The PDisks styling is consistent across both pages using the same CSS classes and component structure. I'm unable to provide screenshots due to the development environment limitations, but the code changes ensure the correct behavior and styling consistency. |
…nodes Co-authored-by: adameat <[email protected]>
... Fixed both issues in commit f4a2b10:
Both columns maintain correct ordering (PDisks → Tablets) and remain optional (disabled by default). The fixes address the root causes: missing tablets data flow for storage nodes and missing width configuration for cluster nodes PDisks column. |
Do not create a column yourself, export and use Also use |
…odesResponse Co-authored-by: artemmufazalov <[email protected]>
Fixed in commit 314268b:
This ensures both tablets data availability and consistent PDisks column implementation across storage and cluster pages. |
@copilot delete not used interfaces and css classes that you have added |
Co-authored-by: artemmufazalov <[email protected]>
Cleaned up unused code in commit db7d495:
The code is now cleaner and uses existing shared implementations consistently. |
This PR refactors the cluster nodes implementation to use the existing storage nodes infrastructure, ensuring consistency and proper data flow across both pages.
Changes Made
Code Reuse and Consistency
getPDisksColumn
from storage nodes and reused it in cluster nodes instead of maintaining duplicate implementationsprepareNodesData
toprepareStorageNodesResponse
PreparedStorageNode
instead ofNodesPreparedEntity
Benefits
Result
Both optional columns (PDisks and Tablets) now work correctly across storage and cluster nodes pages with:
Fixes #2716.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.