Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump activesupport and actionview #123

Closed
wants to merge 1 commit into from
Closed

Bump activesupport and actionview #123

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 18, 2023

Bumps activesupport and actionview. These dependencies needed to be updated together.
Updates activesupport from 7.0.3 to 7.0.4.1

Release notes

Sourced from activesupport's releases.

v7.0.4.1

This is a security release. More information is available in our security announcements forum: https://discuss.rubyonrails.org/c/security-announcements/9

Active Support

Active Model

  • No changes.

Active Record

  • Make sanitize_as_sql_comment more strict

    Though this method was likely never meant to take user input, it was attempting sanitization. That sanitization could be bypassed with carefully crafted input.

    This commit makes the sanitization more robust by replacing any occurrances of "/" or "/" with "/ " or " /". It also performs a first pass to remove one surrounding comment to avoid compatibility issues for users relying on the existing removal.

    This also clarifies in the documentation of annotate that it should not be provided user input.

    [CVE-2023-22794]

  • Added integer width check to PostgreSQL::Quoting

    Given a value outside the range for a 64bit signed integer type PostgreSQL will treat the column type as numeric. Comparing integer values against numeric values can result in a slow sequential scan.

    This behavior is configurable via ActiveRecord::Base.raise_int_wider_than_64bit which defaults to true.

    [CVE-2022-44566]

Action View

... (truncated)

Changelog

Sourced from activesupport's changelog.

Rails 7.0.4.1 (January 17, 2023)

Rails 7.0.4 (September 09, 2022)

  • Redis cache store is now compatible with redis-rb 5.0.

    Jean Boussier

  • Fix NoMethodError on custom ActiveSupport::Deprecation behavior.

    ActiveSupport::Deprecation.behavior= was supposed to accept any object that responds to call, but in fact its internal implementation assumed that this object could respond to arity, so it was restricted to only Proc objects.

    This change removes this arity restriction of custom behaviors.

    Ryo Nakamura

Rails 7.0.3.1 (July 12, 2022)

  • No changes.
Commits
  • 23e0345 Version 7.0.4.1
  • 2164d4f Avoid regex backtracking in Inflector.underscore
  • 8015c2c Version 7.0.4
  • ff27758 Revert "Merge pull request #44695 from Edouard-chin/ec-tagger-logger-broadcast"
  • 4a1f224 Merge pull request #45882 from rails/short-inspect-on-test-case
  • a3bd3b5 Backport Redis 5.0 compatibility
  • 67f37ac Fix flaky tests for RedisCacheStore
  • c520e38 Document AS::Cache::MemCacheStore#write options [ci-skip]
  • a74b650 Document AS::Cache::Store#initialize options [ci-skip]
  • f7a82bf Document AS::Cache::Store#read options [ci-skip]
  • Additional commits viewable in compare view

Updates actionview from 7.0.3 to 7.0.4.1

Release notes

Sourced from actionview's releases.

v7.0.4.1

This is a security release. More information is available in our security announcements forum: https://discuss.rubyonrails.org/c/security-announcements/9

Active Support

Active Model

  • No changes.

Active Record

  • Make sanitize_as_sql_comment more strict

    Though this method was likely never meant to take user input, it was attempting sanitization. That sanitization could be bypassed with carefully crafted input.

    This commit makes the sanitization more robust by replacing any occurrances of "/" or "/" with "/ " or " /". It also performs a first pass to remove one surrounding comment to avoid compatibility issues for users relying on the existing removal.

    This also clarifies in the documentation of annotate that it should not be provided user input.

    [CVE-2023-22794]

  • Added integer width check to PostgreSQL::Quoting

    Given a value outside the range for a 64bit signed integer type PostgreSQL will treat the column type as numeric. Comparing integer values against numeric values can result in a slow sequential scan.

    This behavior is configurable via ActiveRecord::Base.raise_int_wider_than_64bit which defaults to true.

    [CVE-2022-44566]

Action View

... (truncated)

Changelog

Sourced from actionview's changelog.

Rails 7.0.4.1 (January 17, 2023)

  • No changes.

Rails 7.0.4 (September 09, 2022)

  • Guard against ActionView::Helpers::FormTagHelper#field_name calls with nil object_name arguments. For example:

    <%= fields do |f| %>
  <%= f.field_name :body %>
<% end %>

    Sean Doyle

  • Strings returned from strip_tags are correctly tagged html_safe?

    Because these strings contain no HTML elements and the basic entities are escaped, they are safe to be included as-is as PCDATA in HTML content. Tagging them as html-safe avoids double-escaping entities when being concatenated to a SafeBuffer during rendering.

    Fixes rails/rails-html-sanitizer#124

    Mike Dalessio

Rails 7.0.3.1 (July 12, 2022)

  • No changes.
Commits
  • 23e0345 Version 7.0.4.1
  • 8015c2c Version 7.0.4
  • deb8087 Standardize format of "Options" subsections [ci-skip]
  • c5a407d Linkify code references [ci-skip]
  • e874cf5 Fix typos [ci-skip]
  • b3e79be Merge pull request #45675 from hirotaka/fix_date_select_with_locale
  • 196e0f7 Merge pull request #45572 from fatkodima/fix-cached-missing-translations
  • 0f4be71 Merge pull request #45563 from diegomichel/fixes-rubydoc-info-links
  • a730810 Merge branch '7-0-sec' into 7-0-stable
  • 04972d9 Preparing for 7.0.3.1 release
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot
Bump activesupport and actionview
650a479 
Bumps [activesupport](https://github.com/rails/rails) and [actionview](https://github.com/rails/rails). These dependencies needed to be updated together.

Updates `activesupport` from 7.0.3 to 7.0.4.1
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v7.0.4.1/activesupport/CHANGELOG.md)
- [Commits](rails/rails@v7.0.3...v7.0.4.1)

Updates `actionview` from 7.0.3 to 7.0.4.1
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v7.0.4.1/actionview/CHANGELOG.md)
- [Commits](rails/rails@v7.0.3...v7.0.4.1)

---
updated-dependencies:
- dependency-name: activesupport
  dependency-type: direct:production
- dependency-name: actionview
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 18, 2023
@0crat
Copy link
Collaborator

0crat commented Jan 18, 2023

There is an unrecoverable failure on my side. Please, submit it here:

PID: 4@72e5e8b6-c50f-4c9a-ae22-78cc3eaaab86, thread: PQ-C6MATTB7E
com.jcabi.xml.StrictXML[124] java.lang.IllegalArgumentException: 2 error(s) in XML document: -1:-1: cvc-pattern-valid: Value 'dependabot[bot]' is not facet-valid with respect to pattern '[a-z0-9\-]{3,}' for type 'login'.;-1:-1: cvc-type.3.1.3: The value 'dependabot[bot]' of element 'login' is not valid.

1.0-SNAPSHOT: CID: c444f7d6-c418-4c65-987d-a1937cf459e6, Type: "Job was added to WBS"

@yegor256
Copy link
Owner

@rultor please, try to merge

@rultor
Copy link
Collaborator

rultor commented Jan 18, 2023

@rultor please, try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Jan 18, 2023

@rultor please, try to merge

@dependabot[bot] @yegor256 Oops, I failed. You can see the full log here (spent 5min)

WARNING: Illegal reflective access by com.fasterxml.jackson.databind.util.ClassUtil (file:/home/r/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.5.3/jackson-databind-2.5.3.jar) to field java.lang.Throwable.cause
WARNING: Please consider reporting this to the maintainers of com.fasterxml.jackson.databind.util.ClassUtil
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
[\u001b[1;34mINFO\u001b[m] Waiting for table 'sn-endpoints' to become active
[\u001b[1;34mINFO\u001b[m] Table 'sn-endpoints' is now ready for use
DynamoDB Local table: ACTIVE
DynamoDB Local is running in PID 11396
WARNING: Nokogiri was built against libxml version 2.10.3, but has dynamically loaded 2.9.14
[\u001b[1;34mINFO\u001b[m] Waiting for table 'sn-pings' to become active
[\u001b[1;34mINFO\u001b[m] Table 'sn-pings' is now ready for use
[\u001b[1;34mINFO\u001b[m] 
[\u001b[1;34mINFO\u001b[m] \u001b[1m--- \u001b[0;32mjcabi-dynamodb-maven-plugin:0.9:wait\u001b[m \u001b[1m(dynamodb-integration-test)\u001b[m @ \u001b[36mdynamodb-local\u001b[0;1m ---\u001b[m
[\u001b[1;34mINFO\u001b[m] DynamoDB Local is listening on port 41599... (Ctrl-C to stop)
I, [2023-01-18T19:32:17.734503 #11518]  INFO -- sentry: ** [Raven] Raven 3.1.2 configured not to capture errors: No host specified, no public_key specified, no project_id specified
Coverage report generated for Unit Tests to /home/r/repo/coverage. 221 / 482 LOC (45.85%) covered.
Loaded suite /usr/local/rvm/gems/ruby-2.7.0/gems/rake-13.0.6/lib/rake/rake_test_loader
Started
\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[34mO\u001b[0m
===============================================================================
Omission: \u001b[44;37;1mIt does not work for some reason, even though HTML is valid\u001b[0m [test_it_renders_valid_html(AppTest)]
/home/r/repo/test/test_sixnines.rb:53:in `test_it_renders_valid_html'
===============================================================================
\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m\u001b[32;1m.\u001b[0m
Finished in 13.031028904 seconds.
\u001b[34m-------------------------------------------------------------------------------\u001b[0m
52 tests, 65 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications
100% passed
\u001b[34m-------------------------------------------------------------------------------\u001b[0m
3.99 tests/s, 4.99 assertions/s
Running RuboCop...
DynamoDB Local killed in PID 11396
DynamoDB Local killed in PID 11396DynamoDB Local killed in PID 11396

DynamoDB Local killed in PID 11396
DynamoDB Local killed in PID 11396
DynamoDB Local killed in PID 11396
DynamoDB Local killed in PID 11396
DynamoDB Local killed in PID 11396\u001b[0m\u001b[0m
DynamoDB Local killed in PID 11396
[\u001b[1;34mINFO\u001b[m] #stop(41599): in 18.07ms
DynamoDB Local killed in PID 11396
DynamoDB Local killed in PID 11396
DynamoDB Local killed in PID 11396
Inspecting 48 files
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m

48 files inspected, \u001b[32mno offenses\u001b[0m detected
grep -q -r '2017-2023'     --include '*.rb'     --include '*.txt'     --include 'Rakefile'     .
rake aborted!
Command failed with status (1): [grep -q -r '2017-2023'     --include '*.rb...]
/home/r/repo/Rakefile:83:in `block in <top (required)>'
/usr/local/rvm/gems/ruby-2.7.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
/usr/local/rvm/gems/ruby-2.7.0/bin/ruby_executable_hooks:24:in `eval'
/usr/local/rvm/gems/ruby-2.7.0/bin/ruby_executable_hooks:24:in `<main>'
Tasks: TOP => default => copyright
(See full trace by running task with --trace)
DynamoDB Local killed in PID 11396
container c2b5a0b32c329605aaadfa888d50a7a99ebd247cc64ef34f0d2e5c10e5192059 is dead
Wed 18 Jan 2023 08:32:52 PM CET

@0crat
Copy link
Collaborator

0crat commented Jan 18, 2023

@null/z everybody who has role REV is banned at #123; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Jan 23, 2023

@null/z everybody who has role REV is banned at #123; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Jan 28, 2023

@null/z everybody who has role REV is banned at #123; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Feb 2, 2023

@null/z everybody who has role REV is banned at #123; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Feb 7, 2023

@null/z everybody who has role REV is banned at #123; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 15, 2023

Superseded by #126.

@dependabot dependabot bot closed this Mar 15, 2023
@dependabot dependabot bot deleted the dependabot/bundler/activesupport-and-actionview-7.0.4.1 branch March 15, 2023 23:06
@0crat 0crat removed the 0crat/scope label Mar 21, 2023
@0crat
Copy link
Collaborator

0crat commented Mar 21, 2023

Pull request #123 was not merged, no payment for ARC, see §28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0crat/role/REV dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0crat @yegor256 @rultor