Skip to content

fix: rename groth16/plonk to gnark_groth16 and gnark_plonk to avoid ambiguity with circom #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: staging
Choose a base branch
from
Open

fix: rename groth16/plonk to gnark_groth16 and gnark_plonk to avoid ambiguity with circom #1999

wants to merge 6 commits into from

Conversation

JuArce
Copy link
Collaborator

@JuArce JuArce commented Jun 24, 2025 •
edited
Loading

Rename groth16/plonk to gnark_groth16 and gnark_plonk to avoid ambiguity with circom

Description

This PR changes gnark names to avoid ambiguity with circom

Closes #1998

Type of change

  • Bug fix

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@JuArce JuArce self-assigned this Jun 24, 2025
@JuArce JuArce linked an issue Jun 24, 2025 that may be closed by this pull request
fix: rename groth16/plonk to gnark_groth16 and gnark_plonk to avoid ambiguity with circom #1998
Open
JuArce added 2 commits June 25, 2025 14:29
@JuArce
Merge branch 'refs/heads/staging' into 1998-fix-rename-groth16plonk-t…
f80eb84 
…o-gnark_groth16-and-gnark_plonk-to-avoid-ambiguity-with-circom

# Conflicts:
#	Makefile
#	crates/batcher/src/zk_utils/mod.rs
#	crates/cli/send_proof_with_random_address.sh
@JuArce
refactor: rename gnark ffis functions
33e5c2c
@JuArce JuArce marked this pull request as ready for review June 25, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximopalopoli maximopalopoli maximopalopoli approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@JuArce JuArce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: rename groth16/plonk to gnark_groth16 and gnark_plonk to avoid ambiguity with circom
2 participants
@JuArce @maximopalopoli