Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rand 0.8 -> 0.9 #3808

Merged
merged 3 commits into from
Feb 21, 2025
Merged

rand 0.8 -> 0.9 #3808

merged 3 commits into from
Feb 21, 2025

Conversation

Madoshakalaka
Copy link
Member

rand new version 0.9 requires some special RUSTFLAG to build for wasm and renamed a bunch of functions.

Copy link

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)

✅ None of the examples has changed their size significantly.

Copy link

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 290.995 314.252 293.393 7.330
Hello World 10 494.448 535.904 509.431 18.115
Function Router 10 1594.612 1612.562 1601.646 5.898
Concurrent Task 10 1005.935 1007.104 1006.540 0.365
Many Providers 10 1075.936 1142.335 1100.499 24.287

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 310.414 312.162 310.722 0.512
Hello World 10 488.791 523.790 499.290 10.627
Function Router 10 1601.699 1626.356 1608.473 7.272
Concurrent Task 10 1005.904 1007.185 1006.680 0.401
Many Providers 10 1109.181 1138.358 1122.262 8.118

Copy link
Member

@WorldSEnder WorldSEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. For reference, the relevant getrandom docs for the new getrandom_backend flag.

@Madoshakalaka
Copy link
Member Author

Madoshakalaka commented Feb 21, 2025

To add on this, some examples like keyed_list have to stay on 0.8 for now because the dependency lipsum uses 0.8 and doesn't expose enough internals to be vendored easily.

@Madoshakalaka Madoshakalaka merged commit 3c6fed4 into yewstack:master Feb 21, 2025
21 checks passed
@Madoshakalaka Madoshakalaka mentioned this pull request Mar 1, 2025
@Madoshakalaka Madoshakalaka added the A-examples Area: The examples label Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-examples Area: The examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants