Skip to content

Commit

Permalink
Merge pull request #731 from yext/hotfix/v1.20.1
Browse files Browse the repository at this point in the history
**Bugfixes**
- Remove an extraneous comma from the vertical-full-page-map template config (#725)
- Fix a layout bug with custom headers and footers on mobile list view on the vertical-full-page-map template (#729)
- Fix styling of NLP filters when no collapsible-filters are present (#728)
  • Loading branch information
cea2aj authored Apr 19, 2021
2 parents 7cd08d3 + fd8504a commit 3721829
Show file tree
Hide file tree
Showing 30 changed files with 500 additions and 416 deletions.
13 changes: 11 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "answers-hitchhiker-theme",
"version": "1.20.0",
"version": "1.20.1",
"description": "A starter answers theme for hitchhikers",
"scripts": {
"test": "cross-env NODE_ICU_DATA=node_modules/full-icu jest --verbose",
Expand Down
2 changes: 1 addition & 1 deletion static/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion static/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "answers-hitchhiker-theme",
"version": "1.20.0",
"version": "1.20.1",
"description": "Toolchain for use with the HH Theme",
"main": "Gruntfile.js",
"scripts": {
Expand Down
9 changes: 8 additions & 1 deletion static/scss/answers/interactive-map/VerticalFullPageMap.scss
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,6 @@

&-resultsHeaderTop {
display: flex;
justify-content: space-between;
padding-left: 16px;
}

Expand Down Expand Up @@ -456,6 +455,14 @@
display: none;
}
}

&-mapWrapper
{
// Hide the map above the screen. This has better performance than
// display: none since the map does not have to re-render
position: fixed;
top: calc(-2 * var(--yxt-maps-mobile-height));
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion templates/vertical-full-page-map/page-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
//"enablePinClustering": true, // Cluster pins on the map that are close together. Defaults false
"mapProvider": "MapBox", // The name of the provider (e.g. Mapbox, Google)
"noResults": {
"displayAllResults": false, // Set to FALSE to hide results on the map when a search returns no results
"displayAllResults": false // Set to FALSE to hide results on the map when a search returns no results
},
"pin": {
"default": { // The pin in its normal state
Expand Down
8 changes: 8 additions & 0 deletions test-site/.gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
!config/global_config.json
!config/locale_config.json
!config/index.json
!pages/index.html.hbs
public/
config/
pages/
cards/
directanswercards/
Gruntfile.js
package-lock.json
package.json
Expand Down
8 changes: 8 additions & 0 deletions test-site/config-overrides/events.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"pageTitle": "Events",
"verticalsToConfig": {
"events": {
"label": "Events"
}
}
}
14 changes: 14 additions & 0 deletions test-site/config-overrides/faqs.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"pageTitle": "FAQ Search",
"componentSettings": {
"QASubmission": {
"entityId": "12345",
"privacyPolicyUrl": ""
}
},
"verticalsToConfig": {
"faq": {
"label": "FAQs"
}
}
}
22 changes: 22 additions & 0 deletions test-site/config-overrides/locations.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"componentSettings": {
"Facets": {
"expand": false,
"showMore": false,
"searchOnChange": true
},
"SortOptions": {
"options": [
{
"type": "ENTITY_DISTANCE",
"label": "Distance"
}
]
}
},
"verticalsToConfig": {
"KM": {
"label": "Locations"
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"componentSettings": {
"Facets": {
"expand": false,
"showMore": false,
"searchOnChange": true
}
}
}
35 changes: 35 additions & 0 deletions test-site/config-overrides/people.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
{
"pageTitle": "People",
"componentSettings": {
"Facets": {
"expand": false,
"showMore": false,
"searchOnChange": true,
"fields": {
"c_puppyPreference": {
"searchable": true,
"fieldLabels": {
"Frodo": "FRODO !!!",
"Marty": "MARTY !!!"
}
},
"c_employeeDepartment": {
"fieldLabels": {
"Strategy": "STRATEGY !!!"
}
}
}
},
"SortOptions": {
"options": [{
"type": "RELEVANCE",
"label": "Relevance"
}]
}
},
"verticalsToConfig": {
"people": {
"label": "People"
}
}
}
67 changes: 0 additions & 67 deletions test-site/config/faqs.json

This file was deleted.

2 changes: 1 addition & 1 deletion test-site/config/global_config.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"sdkVersion": "1.7", // The version of the Answers SDK to use
"sdkVersion": "1.8", // The version of the Answers SDK to use
"apiKey": "2d8c550071a64ea23e263118a2b0680b", // The answers api key found on the experiences page. This will be provided automatically by the Yext CI system
// "experienceVersion": "<REPLACE ME>", // the Answers Experience version to use for API requests. This will be provided automatically by the Yext CI system
// "businessId": "<REPLACE ME>", // The business ID of the account. This will be provided automatically by the Yext CI system
Expand Down
2 changes: 1 addition & 1 deletion test-site/config/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"cardType": "documentsearch-standard"
},
"FIELD_VALUE": {
"cardType": "allfields-standard"
"cardType": "allfields-custom"
}
}
},
Expand Down
88 changes: 0 additions & 88 deletions test-site/config/locations.json

This file was deleted.

Loading

0 comments on commit 3721829

Please sign in to comment.