-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve vulnerabilities #1167
Merged
Merged
Resolve vulnerabilities #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmanu1
reviewed
Feb 5, 2024
EmilyZhang777
commented
Feb 7, 2024
nmanu1
reviewed
Feb 7, 2024
nmanu1
reviewed
Feb 7, 2024
nmanu1
reviewed
Feb 9, 2024
EmilyZhang777
commented
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But I can't approve it since I started this PR
Merged
nmanu1
added a commit
that referenced
this pull request
Feb 20, 2024
### Fixes - Resolve vulnerabilities (#1167) - Remove `span` styling and bump answers-search-ui version to 1.17 so icon `div`s are changed to `span`s without affecting their styling (#1169, #1170) - Note, any custom styling that is applied by targeting `div`s or `span`s directly may be impacted by this change. This could result in previously applied styles no longer being applied to these icons, or other styles inadvertently being applied to the icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the following vulnerabilities:
webpack
to version 5.90.1 to resolve vulnerability to Improper Access Control in versions lower than 5.76.0http-cache-semantics
to version 4.1.1 to resolve vulnerability to Inefficient Regular Expression Complexity in versions lower than 4.1.1get-func-name
to version 2.0.2 to resolve vulnerability to Uncontrolled Resource Consumption / Inefficient Regular Expression Complexity in versions lower than 2.0.1J=VULN-37755 - VULN-37760, VULN-38372, VULN-38400, VULN-38433