Fix components randomly disappearing after noresults searches (#1371)

#1366 #1367 J=SLAP-1238
yext · Apr 9, 2021 · c6cbee1 · c6cbee1
1 parent e7dc469
commit c6cbee1
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 5 deletions.
diff --git a/src/ui/components/component.js b/src/ui/components/component.js
@@ -20,8 +20,13 @@ export default class Component {
     this.moduleId = null;
 
     /**
-     * Unique name of this component instance
-     * Used to distinguish between other components of the same type
+     * A unique id number for the component.
+     * @type {number}
+     */
+    this.uniqueId = systemConfig.uniqueId;
+
+    /**
+     * Name of this component instance.
      * @type {String}
      */
     this.name = config.name || this.constructor.type;

diff --git a/src/ui/components/componentmanager.js b/src/ui/components/componentmanager.js
@@ -19,6 +19,11 @@ export default class ComponentManager {
      */
     this._activeComponents = [];
 
+    /**
+     * A counter for the id the give to the next component that is created.
+     */
+    this._componentIdCounter = 0;
+
     /**
      * A local reference to the core library dependency
      *
@@ -109,8 +114,10 @@ export default class ComponentManager {
       core: this._core,
       renderer: this._renderer,
       analyticsReporter: this._analyticsReporter,
-      componentManager: this
+      componentManager: this,
+      uniqueId: this._componentIdCounter
     };
+    this._componentIdCounter++;
 
     let componentClass = COMPONENT_REGISTRY[componentType];
     if (!componentClass) {
@@ -169,8 +176,10 @@ export default class ComponentManager {
   remove (component) {
     this._core.globalStorage.off('update', component.moduleId);
 
-    const index = this._activeComponents.findIndex(c => c.name === component.name);
-    this._activeComponents.splice(index, 1);
+    const index = this._activeComponents.findIndex(c => c.uniqueId === component.uniqueId);
+    if (index !== -1) {
+      this._activeComponents.splice(index, 1);
+    }
   }
 
   /**

diff --git a/src/ui/components/filters/facetscomponent.js b/src/ui/components/filters/facetscomponent.js
@@ -184,6 +184,7 @@ export default class FacetsComponent extends Component {
 
     if (this._filterbox) {
       this._filterbox.remove();
+      this._filterbox = null;
     }
 
     let { filters, resultsContext } = this._state.get();