Skip to content

Commit

Permalink
Use defaulted verticalKey in the LocationBias component.
Browse files Browse the repository at this point in the history
The LocationBias component has the ability to provide a default for the
verticalKey, if one is not provided in the component config. The default is
the Search Config's verticalKey (if it exists). In the component's _doSearch
method, we were not using the defaulted key. This led to a TechOps reported
by the Hitchhikers. Specifically, in the Theme they had set a Search Config
with a verticalKey. They were not passing verticalKey to the LocationBias
component itself, however. This was causing the component to try and execute
a vertical search with an undefined verticalKey.

T=377422
TEST=manual

Pointed the failing HH site to my local version of the SDK. I verified that
the vertical search issued by the LocationBias component gave a 200 response.
  • Loading branch information
tmeyer2115 committed Jan 8, 2021
1 parent 3668f5c commit e59d3b6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/ui/components/search/locationbiascomponent.js
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ export default class LocationBiasComponent extends Component {

_doSearch () {
if (this._verticalKey) {
this.core.verticalSearch(this._config.verticalKey, {
this.core.verticalSearch(this._verticalKey, {
setQueryParams: true,
useFacets: true
});
Expand Down

0 comments on commit e59d3b6

Please sign in to comment.