Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

techops10133: fix multiple search bars on a page #1837

Merged
merged 1 commit into from
Oct 4, 2023
Merged

techops10133: fix multiple search bars on a page #1837

merged 1 commit into from
Oct 4, 2023

Conversation

jesuyedavid
Copy link
Contributor

No description provided.

benmcginnis
benmcginnis approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@benmcginnis benmcginnis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, are there any other ids that we need to scope like this? also have you tried running your test page through any accessibility tools like Chrome Lighthouse?

@jesuyedavid jesuyedavid merged commit 002cb23 into master Oct 4, 2023
13 of 19 checks passed
@jesuyedavid jesuyedavid deleted the hotfixv1.16.2 branch October 4, 2023 17:02
@cea2aj cea2aj restored the hotfixv1.16.2 branch October 4, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cea2aj cea2aj cea2aj left review comments

@benmcginnis benmcginnis benmcginnis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jesuyedavid @benmcginnis @cea2aj