Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade @babel/traverse #1851

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Upgrade @babel/traverse #1851

merged 2 commits into from
Dec 4, 2023

Conversation

nmanu1
Copy link
Contributor

@nmanu1 nmanu1 commented Dec 1, 2023

Upgrade @babel/traverse from v7.17.10 to 7.23.5 to address a critical vulnerability in the package.

J=VULN-38480
TEST=auto

@coveralls
Copy link

coveralls commented Dec 1, 2023 •
edited
Loading

Coverage Status

coverage: 61.411%. remained the same
when pulling 132a682 on dev/babel-traverse-vulnerability
into 0f8a1a6 on hotfix/v1.16.5.

@nmanu1 nmanu1 requested a review from a team December 1, 2023 22:46
benmcginnis
benmcginnis approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@benmcginnis benmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but do we need to set the version in the package.json or are we just relying on the package lock?

@nmanu1
Copy link
Contributor Author

nmanu1 commented Dec 4, 2023

lgtm, but do we need to set the version in the package.json or are we just relying on the package lock?

it's a transitive dependency, so we don't currently specify a version in our package.json

@benmcginnis
Copy link
Member

Ah ok great

@nmanu1 nmanu1 merged commit 31b769a into hotfix/v1.16.5 Dec 4, 2023
12 of 13 checks passed
@nmanu1 nmanu1 deleted the dev/babel-traverse-vulnerability branch December 4, 2023 19:32
@nmanu1 nmanu1 mentioned this pull request Dec 4, 2023
Merged
nmanu1 added a commit that referenced this pull request Dec 5, 2023
@nmanu1
Version 1.16.5 (#1852)
dc3b171 
### Fixes
- Upgraded `@babel/traverse` version to address a vulnerability in the package (#1851)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmcginnis benmcginnis benmcginnis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmanu1 @coveralls @benmcginnis