-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump browserify-sign to v4.2.3 #1869
Conversation
Merge master (v1.17.0) into develop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you also check that running the build and using the generated bundles in the Theme test site was fine? it looks like browserify-sign is dep of a library we use for bundling, so it would affect our build step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change should point to a hotfix branch if we're making a new version, or develop if we're not
yep! Tested HH theme still works with a local build. |
Bump browserify-sign to v4.2.3 to resolve a vulnerability.
J=VULN-38744
TEST=auto,manual
Ran
npm run test
andnpm run acceptance
. Rannpx serve -p 9999
and clicked around.