Answers SDK: add cloudChoice support #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that cloudChoice is a param inside of search-core, this CR adds support for setting it in the SDK, in the init() function, including setting the old behavior as the default. It is not needed elsewhere like with the CLOUD_REGION setting, as that is used for things like analytics tracking. J=WAT-4375 TEST=auto Ran test suite
|
Honestly not too familiar with manual testing of just the SDK. Willing to look into it, but figured I'd put this up since it's smaller and also I'm heading out early today. |
Merged
Fondryext
added a commit
that referenced
this pull request
Sep 13, 2024
**Changes** - Add cloudChoice parameter, allowing users to choose which cloud provider will be used for their searches #1896
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that cloudChoice is a param inside of search-core, this CR adds support for setting it in the SDK, in the init() function, including setting the old behavior as the default. It is not needed elsewhere like with the CLOUD_REGION setting, as that is used for things like analytics tracking.
J=WAT-4375
TEST=auto
Ran test suite