ksearch: add cloud choice to analytics reporting #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR leverages the new cloud provider-specific endpoints for analytics reporting. Also consolidates old logic now that one url is replacing all older ones. J=WAT-4461 TEST=manual, auto Updated unit tests. Ran locally with gcp and saw expected analytics endpoint hit.
vijay267
reviewed
Oct 11, 2024
vijay267
approved these changes
Oct 11, 2024
Merged
Fondryext
added a commit
that referenced
this pull request
Oct 15, 2024
**Changes** - Adjusts analytics urls to leverage new endpoints and respect cloudChoice #1904
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages the new cloud provider-specific endpoints for analytics reporting. Also consolidates old logic now that one url is replacing all older ones.
J=WAT-4461
TEST=manual, auto
Updated unit tests. Ran locally with gcp and saw expected analytics endpoint hit.