ApiError for better response error details #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbramblett
reviewed
May 6, 2024
nbramblett
approved these changes
May 6, 2024
yen-tt
added a commit
to yext/chat-headless
that referenced
this pull request
May 6, 2024
bump chat-core version to v0.8.0 to get changes from yext/chat-core#32 J=CLIP-1189 TEST=manual&auto see that unit tests passed build chat-headless and link the library locally to chat-ui-react. Force an internal error using yen-bot-2 (v18)'s CHIT_CHAT goal. See that the thrown error is instance of ApiError and contains the expected new fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a custom Error, ApiError, which stores additional information:
statusCodefor the request, as well asapiCodeandtypefrommeta.errorsfield originates from Chat API response.This allow higher-level Chat libraries to check for statusCode and implement retry logic for responses with 5XX status code.
Will deploy new minor version (v0.8.0)
J=CLIP-1189
TEST=manual&auto
see that unit tests passed
build chat-core and link the library locally to chat-headless and chat-ui-react. Force an internal error using yen-bot-2 (v18)'s CHIT_CHAT goal. See that the thrown error is instance of ApiError and contains the expected new fields.