Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display feedback buttons on mobile by default #82

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

anguyen-yext2
Copy link
Contributor

J=CLIP-1309
TEST=manual

verified on test-site that buttons are only displayed on hover for desktop mode and always displayed for mobile mode

J=CLIP-1309
TEST=manual

verified on test-site that buttons are only displayed on hover for desktop mode and always displayed for mobile mode
@anguyen-yext2 anguyen-yext2 requested a review from a team as a code owner July 10, 2024 16:44
@anguyen-yext2 anguyen-yext2 merged commit 1e4b116 into main Jul 10, 2024
8 of 9 checks passed
@anguyen-yext2 anguyen-yext2 deleted the dev/display-feedback-buttons branch July 10, 2024 17:07
@yen-tt yen-tt restored the dev/display-feedback-buttons branch July 18, 2024 17:42
@yen-tt yen-tt mentioned this pull request Jul 18, 2024
yen-tt added a commit that referenced this pull request Jul 18, 2024
the following changes is missing in main. remerging them:
#81
#82
#83

omitting react-markdown update change because it's ESM only and we support both esm and commonjs right now (#80)
@yen-tt yen-tt deleted the dev/display-feedback-buttons branch July 18, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants