Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Vulnerabilities #330

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Conversation

EmilyZhang777
Copy link
Contributor

@EmilyZhang777 EmilyZhang777 commented Jan 31, 2024

This PR resolves the following vulnerabilities

Bump tmpl's version to 1.0.5 to avoid uncontrolled resource consumption when formatting a string
J=VULN-38389
TEST=auto

Ran npm run test. Also made sure running jambo commands locally works.

@coveralls
Copy link

coveralls commented Jan 31, 2024

Coverage Status

coverage: 47.814%. remained the same
when pulling 9d2774d on dev/vulnerabilities
into 52fde9e on hotfix/v1.12.5.

Copy link
Contributor

@nmanu1 nmanu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PR description can be updated now that we're only updating tmpl and not jest. I think it's helpful for the description to include exactly which versions are vuln free (e.g. something like `[email protected]+ here). that way we have it for posterity

package.json Outdated Show resolved Hide resolved
@EmilyZhang777
Copy link
Contributor Author

Updated!

@EmilyZhang777 EmilyZhang777 merged commit cb722b9 into hotfix/v1.12.5 Feb 1, 2024
7 checks passed
@EmilyZhang777 EmilyZhang777 deleted the dev/vulnerabilities branch February 1, 2024 19:53
@nmanu1 nmanu1 mentioned this pull request Feb 29, 2024
nmanu1 added a commit that referenced this pull request Feb 29, 2024
### Fixes
- Addressed various vulnerabilities from our dependencies (#330, #332)
@nmanu1 nmanu1 mentioned this pull request Feb 29, 2024
nmanu1 added a commit that referenced this pull request Feb 29, 2024
### Fixes
- Addressed various vulnerabilities from our dependencies (#330, #332)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants