Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade vitest #566

Merged
merged 3 commits into from
Feb 18, 2025
Merged

chore: upgrade vitest #566

merged 3 commits into from
Feb 18, 2025

Conversation

asanehisa
Copy link
Contributor

No description provided.

@asanehisa asanehisa requested a review from a team as a code owner February 18, 2025 14:26
@asanehisa asanehisa marked this pull request as draft February 18, 2025 15:04
@asanehisa asanehisa marked this pull request as ready for review February 18, 2025 15:10
@asanehisa
Copy link
Contributor Author

Ah so tests were running fine locally, but timing out slightly in the github workflow unit tests, had to add a longer timeout time.

@asanehisa asanehisa merged commit 0c819dc into main Feb 18, 2025
21 checks passed
@asanehisa asanehisa deleted the upgrade branch February 18, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkilpatrick mkilpatrick mkilpatrick approved these changes

@jwartofsky-yext jwartofsky-yext jwartofsky-yext left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asanehisa @mkilpatrick @jwartofsky-yext