Update rules closure #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade rules_go * Update gazelle
Updates dom_test.js to not use goog.html.SafeHtml as goog.html.SafeHtml is deprecated.
Legacy struct providers have been deprecated by Bazel. Replacing them with modern providers, will make it possible to simplify and remove legacy handling from Bazel.
Legacy struct providers have been deprecated by Bazel.
…yInfo, WebFilesInfo and ClosureCssLibraryInfo. (bazelbuild#602)
The "to_proto" method on Starlark structs is deprecated and shouldn't be used. Instead, the proto module's "encode_text" function should be used. (https://bazel.build/rules/lib/toplevel/proto) It, along with "to_json", can be disabled in Bazel using the flag --incompatible_struct_has_no_methods The underlying implementation is the same, so there should be no observable changes in final outputs.
This follows a more common provider approach where rules are responsible for providing supplier to helper functions vs. helper functions trying make it workaround with a mix of targets and providers. This also unbundles provider extraction from unfurl to remove implicit and optional behaviors behind it.
- Add CheckTypeSummaryWarningsGuard to ignore errors from ijs files. - Wrap modules in goog.modules for ijs files and sort them. - Add input delimiters to help with debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change syncs our changes with the rules_closure origin