Add generativeDirectAnswer service #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J=CLIP-1226 TEST=auto,manual ran and saw jest test pass. tested the gda endpoint locally via core test site, saw appropriate api resp onse.
Pull Request Test Coverage Report for Build 9369880764Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9369891182Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9370359911Details
💛 - Coveralls |
should have been covered in api response validator
Pull Request Test Coverage Report for Build 9370662744Details
💛 - Coveralls |
nbramblett
reviewed
Jun 4, 2024
Pull Request Test Coverage Report for Build 9372673931Details
💛 - Coveralls |
yen-tt
reviewed
Jun 4, 2024
| /** The text of the user-written query that prompted Search results. */ | ||
| searchTerm: string, | ||
| /** The complete set of Search Results */ | ||
| results: VerticalResults | Record<string, VerticalResults[]> |
There was a problem hiding this comment.
perhaps I missed something, but why is the type a map of key to results? why not just an array of VerticalResults?
There was a problem hiding this comment.
we defined results in GDAApiRequestBody to be of type struct, so we can't pass in array. VerticalResults is for a Vertical Search Result, Record<string, VerticalResults[]> is for a Universal Search Result.
I think there is another way I could accomplish this: keep results to be of type VerticalResults[], then in GDAServiceImpl, convert request.results to object before sending the api request. Something like this:
let results: Object = {}
if (request.results.length === 1) {
results = request.results[1]
} else if (request.results.length > 1) {
results = {verticals: request.results}
}
let me know if you prefer this way, then I can change and test it
There was a problem hiding this comment.
yeah, I think that would work better so user of core don't have to transform the universal results themselves
Pull Request Test Coverage Report for Build 9389260743Details
💛 - Coveralls |
yen-tt
reviewed
Jun 5, 2024
Pull Request Test Coverage Report for Build 9389682713Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9391319665Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9391326582Details
💛 - Coveralls |
yen-tt
reviewed
Jun 6, 2024
Pull Request Test Coverage Report for Build 9403239505Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9403250729Details
💛 - Coveralls |
yen-tt
approved these changes
Jun 6, 2024
EmilyZhang777
approved these changes
Jun 6, 2024
anguyen-yext2
pushed a commit
that referenced
this pull request
Jun 10, 2024
Add generativeDirectAnswer service (#263) J=CLIP-1226 TEST=auto,manual Co-authored-by: Yen Truong <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
anguyen-yext2
added a commit
that referenced
this pull request
Jun 10, 2024
This reverts commit e2fe1fd.
anguyen-yext2
added a commit
that referenced
this pull request
Jun 26, 2024
Fondryext
pushed a commit
that referenced
this pull request
Dec 9, 2024
Add generativeDirectAnswer service (#263) J=CLIP-1226 TEST=auto,manual Co-authored-by: Yen Truong <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J=CLIP-1226
TEST=auto,manual
ran and saw jest test pass.
tested the gda endpoint locally via core test site, saw appropriate api resp
onse.