make queryDurationMillis field optional in VerticalResults
#266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J=CLIP-1318 TEST=auto,manual ran `npm run test`. Tested this change together with the rest of the sdk to confirm that gda is executed successfully after executeVerticalQuery finishes.
Pull Request Test Coverage Report for Build 9619070498Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9619207067Details
💛 - Coveralls |
Fondryext
reviewed
Jun 21, 2024
yen-tt
reviewed
Jun 21, 2024
Pull Request Test Coverage Report for Build 9619312910Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9619373396Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9619367339Details
💛 - Coveralls |
vijay267
approved these changes
Jun 21, 2024
Fondryext
pushed a commit
that referenced
this pull request
Dec 9, 2024
J=CLIP-1318 TEST=auto,manual ran `npm run test`. Tested this change together with the rest of the sdk to confirm that gda is executed successfully after executeVerticalQuery finishes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J=CLIP-1318
TEST=auto,manual
ran
npm run test. Tested this change together with the rest of the sdk changes to confirm that gda is executed successfully after executeVerticalQuery finishes.