search-core: Adding Page Number to Segment #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an optional parameter called pageNumber to Segments.ts
Pull Request Test Coverage Report for Build 9942181701Details
💛 - Coveralls |
|
|
||
| ## Segment.pageNumber property | ||
|
|
||
| The page number of a segment from a pdf |
There was a problem hiding this comment.
I'd prefer to say something like "The page number of the document that the segment came from. Only populated when document is a PDF file."
If you end up changing this, make sure to update other places as well
|
Also, this pr needs to be merged into a hotfix branch instead of master |
vijay267
approved these changes
Jul 15, 2024
EmilyZhang777
approved these changes
Jul 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional parameter called pageNumber to Segments.ts
Test: Existing tests in search-core all pass