Hotfix/v2.5.5 #283
Merged
Hotfix/v2.5.5 #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updated the LiveAPI endpoints that search-core provides so that it provides the cached version of the endpoints. Using the cached endpoints helps improve performance. J=WAT-4442 TEST=manual Built test site with new change, saw that the cached endpoints were being used.
Updates provideEndpointsTest to expect the cached version of the LiveAPI endpoints now that we've updated search-core to supply the cached endpoints rather than the regular ones. J=WAT-4442 TEST=auto provideEndpointsTest.ts passes
This commit revises the endpoint domains provided by LiveAPI so that we supply the cached endpoints for autocompletes and normal endpoints elsewhere. J=WAT-4442 TEST=manual, auto Tests expected to pass pass. Spun up test-site manually, saw expected endpoints.
Fixes provideEndpointsTest so it only expects cached endpoints for autocompletes. J=WAT-4442 TEST=auto Test passes
Use Cached Endpoints
k-gerner
previously approved these changes
Nov 12, 2024
Pull Request Test Coverage Report for Build 11864104902Details
💛 - Coveralls |
Fondryext
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Two thoughts - one, I would expect package-lock.json to have also been updated. Could you make sure npm i is run, so that file is updated as well?
Second, when it's time to merge in to master we're usually a little more standardized with our commit messages. Here is an example: #278 . Note both title and commit message.
Fondryext
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the endpoint for autocompletes to the cached version