-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master (v2.5.7) into develop #288
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the new cloudChoice config property, to allow choosing either all consumer serving regions, or just the ones backed by GCP. By default the Multi option will be used, so default behavior is unchanged. J=WAT-4374 TEST=auto Added new test class --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
**Changes:** - Adds new cloudChoice config property #277
This change updates the autocomplete LiveAPI endpoints that search-core provides so that it provides the cached version of the endpoints. Using the cached endpoints helps improve performance. J=WAT-4442 TEST=manual, auto Built test site with new change, saw that the cached endpoints were being used. Tests pass.
Updating the @babel/plugin-transform-runtime import from 7.17.0 to 7.23.2 to resolve a potential vulnerability. J=VULN-39421 TEST=manual Ran npm run start in test-site, site functioned as expected. Saw package versions were updated in package-lock.json.
search-core: Resolve Vulnerabilities Regenerated package-lock.json and test-site/package-lock.json to ensure that both used updated safe dependencies. J=VULN-39421 TEST=manual Inspected babel dependencies in each file to confirm they used safe versions. * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Automated update to repo's documentation from github action --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Merge master (v2.5.1) into develop
Add generativeDirectAnswer service (#263) J=CLIP-1226 TEST=auto,manual Co-authored-by: Yen Truong <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
J=CLIP-1318 TEST=auto,manual ran `npm run test`. Tested this change together with the rest of the sdk to confirm that gda is executed successfully after executeVerticalQuery finishes.
This PR adds a Source enum type for Function Vertical, updates ResultFactory.ts to handle a function vertical response, and adds auto test. Test: manual, auto Tested with auto test and through test site, ensuring function vertical data appear in the response. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
These three backend types are no longer used/supported, so this PR removes them and their associated code. J=WAT-4331 TEST=auto Updated and ran tests --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This PR adds the new cloudChoice config property, to allow choosing either all consumer serving regions, or just the ones backed by GCP. By default the Multi option will be used, so default behavior is unchanged. J=WAT-4374 TEST=auto Added new test class --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
search-core: Resolve Vulnerabilities Regenerated package-lock.json and test-site/package-lock.json to ensure that both used updated safe dependencies. J=VULN-39421 TEST=manual Inspected babel dependencies in each file to confirm they used safe versions. * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Automated update to repo's documentation from github action --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge master (v2.5.7) into develop