Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.5.1 #176

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Version 2.5.1 #176

merged 1 commit into from
Jul 10, 2024

Conversation

Fondryext
Copy link
Contributor

@Fondryext Fondryext commented Jul 8, 2024

Changes

…175)

This change adds a new param to QueryState, which is used inside
of vertical searches to reuse the previous queryId, if any. It is
then set to false, requiring callers to specify every time that the next
search is a pagination.
J=WAT-4105
TEST=auto

wrote new tests

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@Fondryext Fondryext requested a review from a team July 8, 2024 19:39
@Fondryext Fondryext requested a review from a team as a code owner July 8, 2024 19:39
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9845872886

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 93.056%

Totals Coverage Status
Change from base Build 7669778155: 0.08%
Covered Lines: 342
Relevant Lines: 361

💛 - Coveralls

@Fondryext Fondryext changed the title Add isPagination variable to QueryState, and use for reusing queryId … Version 2.5.1 Jul 9, 2024
@Fondryext Fondryext merged commit 106d9eb into main Jul 10, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants