-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
search-headless: increase search-core version used for function vertical support #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt/search-headless into dev/testing-function-vertical
…xt/search-headless into dev/testing-function-vertical
…3rd party notices check" This reverts commit 60d102f.
… 3rd party notices check" This reverts commit 9ef77c7.
…xt/search-headless into dev/testing-function-vertical
This reverts commit ad42b9f.
Fondryext
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's too bad about all the .md files, but since this is a very small PR otherwise I'm fine to just pull them in here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases search-core version to 2.6.0-beta.3 (and increases search-headless beta version too)
Will also create PRs for search-headless-react and search-ui-react to support function vertical.
Tests: auto, manual
Edited index.js in test-site-node (reverted this before pushing) to confirm function vertical was working as expected. Also ran
npm run test
to ensure no tests failed.