-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge develop into Main #424
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge main (v1.4.0) into develop
Merge main (v1.4.1) into develop
expose a callback prop to be called everytime after input changes in the FilterSearch component. This enables greater customization for our Locators that are built using FilterSearch primarily J=BACK-2765 TEST=manual
…havior, add documentation specify a type for the props passed into onDropdownInputSelect and pass back the searchFields used in the FilterSearch component so we can properly remove/keep the right filters J=BACK-2765 TEST=manual
…pdownInputChange is specified ensure executeFilterSearch is not called in test when onDropdownInputChange is supplied J=BACK-2765 TEST=manual
J=BACK-2765 TEST=manual
…o args move executeFilterSearch check to be outside a callback J=BACK-2765 TEST=manual
This PR addresses the following vulnerabilities under test-site: bump webpack version to 5.90.0 remove real live api key J=VULN-37163,VULN-38428 TEST=auto Ran npm run test. Spun up the test site and confirmed the pages are working.
nmanu1
reviewed
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can't merge directly into master because there are other changes on develop that need to go in a new minor version
Current unit coverage is 92.65223955712129% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.