Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/use updated workflow #435

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:

jobs:
combined_coverage:
uses: yext/slapshot-reusable-workflows/.github/workflows/coverage.yml@v1
uses: yext/slapshot-reusable-workflows/.github/workflows/coverage.yml@dev/update_coverage_reusable_workflow
with:
test_script: npm run build:css && npm run test
secrets:
Expand All @@ -21,9 +21,9 @@ jobs:
runs-on: ubuntu-latest
needs: combined_coverage
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Download the current coverage
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: coverage
path: coverage/
Expand Down
Binary file modified .storybook/snapshots/__snapshots__/mapboxmap--custom-pin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .storybook/snapshots/__snapshots__/mapboxmap--primary.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion docs/search-ui-react.appliedfilters.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@ declare function AppliedFilters(props: AppliedFiltersProps): JSX.Element;

JSX.Element

A React element for the applied filters
A React element for the applied filters.

4 changes: 2 additions & 2 deletions src/components/AppliedFilters.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export interface AppliedFiltersCssClasses {
}

export const builtInCssClasses: Readonly<AppliedFiltersCssClasses> = {
// Use negative margin to remove space above the filters on mobile
// Use negative margin to remove space above the filters on mobile.
appliedFiltersContainer: 'flex flex-wrap -mt-3 md:mt-0 mb-2',
appliedFiltersLoading: 'opacity-50',
nlpFilter: 'border border-gray-200 rounded-3xl px-3 py-1.5 text-sm font-medium text-neutral-dark mr-2 mb-2',
Expand Down Expand Up @@ -56,7 +56,7 @@ const DEFAULT_HIDDEN_FIELDS = ['builtin.entityType'];
* @public
*
* @param props - {@link AppliedFiltersProps}
* @returns A React element for the applied filters
* @returns A React element for the applied filters.
*/
export function AppliedFilters(props: AppliedFiltersProps): JSX.Element {
const isLoading = useSearchState(state => state.searchStatus.isLoading);
Expand Down
Loading