Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function Vertical Support via search-core/headless upgrade #459

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

sahilvaidya
Copy link
Contributor

This change upgrades the version for search-core and search-headless to catch the changes which add support for function verticals. It also adds a function vertical page to the test-site for easier testing. An image of that page is attached.

J=WAT-3474
TEST=auto,manual

Tested via test-site, saw responses returned were upper cased as expected by the plugin, and the source was FUNCTION_VERTICAL.

Screenshot 2024-08-29 at 4 03 26 PM

@sahilvaidya sahilvaidya requested a review from a team as a code owner August 29, 2024 21:12
Copy link
Contributor

Current unit coverage is 91.95736434108527%
Current visual coverage is 79.2817679558011%
Current combined coverage is 92.4455205811138%

@coveralls
Copy link

coveralls commented Aug 29, 2024

Coverage Status

coverage: 85.208%. remained the same
when pulling 125243d on dev/function-vertical
into 6f184f8 on develop.

Copy link
Contributor

@Fondryext Fondryext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sahilvaidya sahilvaidya merged commit 3271cf1 into develop Sep 3, 2024
21 of 22 checks passed
@sahilvaidya sahilvaidya deleted the dev/function-vertical branch September 3, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants