Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ksearch: Add CloudChoice functionality #460

Merged
merged 2 commits into from
Sep 19, 2024
Merged

ksearch: Add CloudChoice functionality #460

merged 2 commits into from
Sep 19, 2024

Conversation

k-gerner
Copy link
Contributor

Adds functionality to set cloud choice

@k-gerner
ksearch: Add CloudChoice functionality
416a288 
Adds functionality to set cloud choice
@k-gerner k-gerner requested a review from a team as a code owner September 18, 2024 21:46
@k-gerner k-gerner changed the base branch from main to hotfix/v1.6.3 September 18, 2024 21:48
@github-actions GitHub Actions
Copy link
Contributor

Current unit coverage is 92.12481426448737%
Current visual coverage is 79.01234567901234%
Current combined coverage is 92.62376237623762%

@coveralls
Copy link

coveralls commented Sep 18, 2024 •
edited
Loading

Coverage Status

coverage: 85.38%. remained the same
when pulling 675cc3f on dev/1.6.3
into ae60515 on hotfix/v1.6.3.

Fondryext
Fondryext approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@Fondryext Fondryext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@k-gerner k-gerner merged commit 38a9c1a into hotfix/v1.6.3 Sep 19, 2024
21 of 22 checks passed
@k-gerner k-gerner deleted the dev/1.6.3 branch September 19, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fondryext Fondryext Fondryext approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-gerner @coveralls @Fondryext