v1.6.3 #462
Merged
v1.6.3 #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds functionality to set cloud choice
|
Current unit coverage is 92.12481426448737% |
Fondryext
reviewed
Sep 19, 2024
There was a problem hiding this comment.
Sorry for not noticing this earlier, but I realized we need to up the version to 1.6.3 in the package.json files and re-run npm i to update package-lock as well. I think you can do that directly in the hotfix branch instead of making another dev branch.
Also, this can wait until you go to merge, but fyi that for pulling into main I'd pref a commit message formatted similarly to:
#457
Update version in package/package-lock
vijay267
approved these changes
Sep 19, 2024
vijay267
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CloudChoice functionality