Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not display GDA citations without name field #468

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

anguyen-yext2
Copy link

J=CLIP-1565
TEST=auto,manual

added and ran jest test
verfied locally using test-site that divider and citations section are not displayed without minimum citation data

J=CLIP-1565
TEST=auto,manual

added and ran jest test
verfied locally using test-site that divider and citations section are not displayed without minimum citation data
@anguyen-yext2 anguyen-yext2 requested a review from a team as a code owner October 1, 2024 14:54
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Current unit coverage is 91.97680038666022%
Current visual coverage is 79.19340054995418%
Current combined coverage is 92.46376811594203%

@coveralls
Copy link

coveralls commented Oct 1, 2024

Coverage Status

coverage: 85.231% (+0.02%) from 85.208%
when pulling 60345dc on dev/gda-citation-fallback
into 3271cf1 on develop.

@anguyen-yext2 anguyen-yext2 merged commit 33e70f7 into develop Oct 1, 2024
21 of 22 checks passed
@anguyen-yext2 anguyen-yext2 deleted the dev/gda-citation-fallback branch October 1, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants