Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main (v1.6.5) into develop #473

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Merge main (v1.6.5) into develop

k-gerner and others added 13 commits September 18, 2024 17:44
Adds functionality to set cloud choice
ksearch: Add CloudChoice functionality
Update version in package/package-lock
### Changes
- Adds CloudChoice functionality
### Changes
- Update version for search-headless-react to pick up CloudChoice changes
This PR adjusts our useId function, which generates ids for
html elements, to also take a 'basename' argument from
callers. This is to help reduce the likelihood of an id
made conflicting with an id somewhere else on the page.

J=WAT-4464
TEST=auto

Ran tests. Was having issues getting the test site running

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
**Fixes**

- Updates id generation to reduce risk of id collision #471
@github-actions github-actions bot requested a review from a team as a code owner October 17, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants